matous-volf/todo-baggins
matous-volf/todo-baggins
1
0
Fork 0
Code Issues 23 Pull Requests Actions Projects 1 Activity

feat: list sorting #42

Merged
matous-volf merged 9 commits from feat/list-sorting into main 2024-09-09 17:09:22 +00:00
Conversation 3 Commits 9 Files Changed 16 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 63e2b20d96 - Show all commits

4
src/components/subtasks_form.rs
View File

@ -64,8 +64,10 @@ pub(crate) fn SubtasksForm(task: Task) -> Element {
match subtasks_query.result().value() {
QueryResult::Ok(QueryValue::Subtasks(subtasks))
| QueryResult::Loading(Some(QueryValue::Subtasks(subtasks))) => {
let mut subtasks = subtasks.clone();
subtasks.sort();
coderabbitai[bot] commented 2024-09-09 17:01:00 +00:00 (Migrated from github.com)
Review
Copy Link

Consider performance implications of cloning and sorting subtasks.

The addition of sorting to the subtasks is a great feature for improving the user interface. However, cloning and then sorting the entire list of subtasks could be performance-intensive, especially with a large number of subtasks. Consider optimizing this by sorting the subtasks in place if the data structure allows, or by using more efficient sorting algorithms or data structures that maintain order.

**Consider performance implications of cloning and sorting subtasks.** The addition of sorting to the subtasks is a great feature for improving the user interface. However, cloning and then sorting the entire list of subtasks could be performance-intensive, especially with a large number of subtasks. Consider optimizing this by sorting the subtasks in place if the data structure allows, or by using more efficient sorting algorithms or data structures that maintain order. <!-- This is an auto-generated comment by CodeRabbit -->
rsx! {
for subtask in subtasks.clone() {
for subtask in subtasks {
div {
coderabbitai[bot] commented 2024-09-09 17:01:00 +00:00 (Migrated from github.com)
Review
Copy Link

Optimize cloning within the rendering loop.

Each iteration of the loop clones subtask and task multiple times, which can lead to significant performance overhead, especially with a large number of subtasks. Consider restructuring the code to minimize cloning, possibly by using references or restructuring the data flow to reduce the need for cloning.

Improve error handling strategy.

The use of panic! in the default case of the match statement handling query results is a risky approach that could lead to crashes in production. Consider replacing this with a more user-friendly error message or a recovery strategy that does not terminate the application.

**Optimize cloning within the rendering loop.** Each iteration of the loop clones `subtask` and `task` multiple times, which can lead to significant performance overhead, especially with a large number of subtasks. Consider restructuring the code to minimize cloning, possibly by using references or restructuring the data flow to reduce the need for cloning. --- **Improve error handling strategy.** The use of `panic!` in the default case of the match statement handling query results is a risky approach that could lead to crashes in production. Consider replacing this with a more user-friendly error message or a recovery strategy that does not terminate the application. <!-- This is an auto-generated comment by CodeRabbit -->
key: "{subtask.id()}",
class: "flex flex-row items-center gap-3",