fix: task sorting
All checks were successful
actionlint check / actionlint check (pull_request) Successful in 6s
conventional pull request title check / conventional pull request title check (pull_request) Successful in 3s
conventional commit messages check / conventional commit messages check (pull_request) Successful in 7s
dotenv-linter check / dotenv-linter check (pull_request) Successful in 7s
GitLeaks check / GitLeaks check (pull_request) Successful in 10s
hadolint check / hadolint check (pull_request) Successful in 11s
htmlhint check / htmlhint check (pull_request) Successful in 44s
markdownlint check / markdownlint check (pull_request) Successful in 40s
Prettier check / Prettier check (pull_request) Successful in 36s
checkov check / checkov check (pull_request) Successful in 1m22s
ShellCheck check / ShellCheck check (pull_request) Successful in 29s
Stylelint check / Stylelint check (pull_request) Successful in 31s
yamllint check / yamllint check (pull_request) Successful in 29s
Rust check / Rust check (pull_request) Successful in 11m42s

This commit is contained in:
2025-12-19 18:40:48 +01:00
parent 999057314a
commit dc3effe640
7 changed files with 28 additions and 16 deletions

View File

@@ -19,7 +19,7 @@ pub(crate) fn CategoryCalendarTaskList() -> Element {
date: today_date,
reoccurrence: None,
time: None,
})?();
})?;
rsx! {
div {

View File

@@ -17,7 +17,7 @@ pub(crate) fn CategoryTodayTaskList() -> Element {
date: today_date,
reoccurrence: None,
time: None,
})?();
})?;
let today_tasks = calendar_tasks
.iter()
.filter(|task| {
@@ -40,7 +40,7 @@ pub(crate) fn CategoryTodayTaskList() -> Element {
})
.cloned()
.collect::<Vec<TaskWithSubtasks>>();
let long_term_tasks = use_tasks_with_subtasks_in_category(Category::LongTerm)?();
let long_term_tasks = use_tasks_with_subtasks_in_category(Category::LongTerm)?;
rsx! {
div {

View File

@@ -3,7 +3,7 @@ use dioxus::prelude::*;
#[component]
pub(crate) fn ProjectList() -> Element {
let projects = use_projects()?();
let projects = use_projects()?;
let mut project_being_edited = use_context::<Signal<Option<Project>>>();
rsx! {

View File

@@ -6,7 +6,7 @@ use dioxus_i18n::t;
#[component]
pub(crate) fn ProjectSelect(initial_selected_id: Option<i32>) -> Element {
let projects = use_projects()?();
let projects = use_projects()?;
rsx! {
select {
name: "project_id",

View File

@@ -8,7 +8,7 @@ use dioxus::prelude::*;
#[component]
pub(crate) fn SubtasksForm(task: Task) -> Element {
let subtasks = use_subtasks_of_task(task.id)?();
let subtasks = use_subtasks_of_task(task.id)?;
let mut new_title = use_signal(String::new);
rsx! {
form {

View File

@@ -13,6 +13,17 @@ use crate::{
},
};
#[allow(clippy::result_large_err)]
fn sort_loader_result<T: Ord + Clone>(
result: Result<Loader<Vec<T>>, Loading>,
) -> Result<Vec<T>, Loading> {
result.map(|loader| {
let mut items_sorted = loader();
items_sorted.sort();
items_sorted
})
}
#[allow(clippy::result_large_err)]
fn use_loader_with_update_subscription<F, T, E>(
mut future: impl FnMut() -> F + 'static,
@@ -40,22 +51,23 @@ where
}
#[allow(clippy::result_large_err)]
pub(crate) fn use_projects() -> Result<Loader<Vec<Project>>, Loading> {
use_loader_with_update_subscription(get_projects).inspect(|projects| projects().sort())
pub(crate) fn use_projects() -> Result<Vec<Project>, Loading> {
let result = use_loader_with_update_subscription(get_projects);
sort_loader_result(result)
}
#[allow(clippy::result_large_err)]
pub(crate) fn use_tasks_with_subtasks_in_category(
filtered_category: Category,
) -> Result<Loader<Vec<TaskWithSubtasks>>, Loading> {
use_loader_with_update_subscription(move || {
) -> Result<Vec<TaskWithSubtasks>, Loading> {
let result = use_loader_with_update_subscription(move || {
get_tasks_with_subtasks_in_category(filtered_category.clone())
})
.inspect(|tasks| tasks().sort())
});
sort_loader_result(result)
}
#[allow(clippy::result_large_err)]
pub(crate) fn use_subtasks_of_task(task_id: i32) -> Result<Loader<Vec<Subtask>>, Loading> {
use_loader_with_update_subscription(move || get_subtasks_of_task(task_id))
.inspect(|subtasks| subtasks().sort())
pub(crate) fn use_subtasks_of_task(task_id: i32) -> Result<Vec<Subtask>, Loading> {
let result = use_loader_with_update_subscription(move || get_subtasks_of_task(task_id));
sort_loader_result(result)
}

View File

@@ -7,7 +7,7 @@ use dioxus::prelude::*;
#[component]
pub(crate) fn CategoryPage(category: Category) -> Element {
let tasks = use_tasks_with_subtasks_in_category(category)?();
let tasks = use_tasks_with_subtasks_in_category(category)?;
rsx! {
TaskList {