matous-volf/todo-baggins
matous-volf/todo-baggins
1
0
Fork 0
Code Issues 23 Pull Requests Actions Projects 1 Activity

ci: GitHub action for code linting #6

Merged
matous-volf merged 5 commits from ci/lint-check into main 2024-08-15 11:55:20 +00:00
Conversation 5 Commits 5 Files Changed 3 +58 -4
3 changed files with 58 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
.github/workflows/conventional-commits.yml vendored
View File

@ -4,12 +4,21 @@ on:
pull_request: pull_request:
types: [ opened, synchronize, reopened, edited ] types: [ opened, synchronize, reopened, edited ]
permissions: { }
coderabbitai[bot] commented 2024-08-15 11:53:17 +00:00 (Migrated from github.com)
Review
Copy Link

Define explicit permissions for security.

The addition of an empty permissions block at the top level is unnecessary since specific permissions are already defined within the build job. Consider removing it to avoid confusion.

- permissions: { }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**Define explicit permissions for security.** The addition of an empty `permissions` block at the top level is unnecessary since specific permissions are already defined within the `build` job. Consider removing it to avoid confusion. ```diff - permissions: { } ``` <!-- suggestion_start --> <details> <summary>Committable suggestion</summary> > :bangbang: **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion ````` </details> <!-- suggestion_end --> <!-- This is an auto-generated comment by CodeRabbit -->
jobs: jobs:
build: build:
name: conventional commits name: conventional commits
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04
permissions:
contents: read
pull-requests: read
packages: read
statuses: write
steps: steps:
- uses: actions/checkout@v3 - name: checkout code
- uses: webiny/action-conventional-commits@v1.3.0 uses: actions/checkout@v3
- name: conventional commits check
uses: webiny/action-conventional-commits@v1.3.0
with: with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

12
.github/workflows/conventional-pull-requests.yml vendored
View File

@ -4,11 +4,19 @@ on:
pull_request: pull_request:
types: [ opened, synchronize, reopened, edited ] types: [ opened, synchronize, reopened, edited ]
permissions: { }
coderabbitai[bot] commented 2024-08-15 11:53:17 +00:00 (Migrated from github.com)
Review
Copy Link

Define explicit permissions for security.

The addition of an empty permissions block at the top level is unnecessary since specific permissions are already defined within the build job. Consider removing it to avoid confusion.

- permissions: { }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**Define explicit permissions for security.** The addition of an empty `permissions` block at the top level is unnecessary since specific permissions are already defined within the `build` job. Consider removing it to avoid confusion. ```diff - permissions: { } ``` <!-- suggestion_start --> <details> <summary>Committable suggestion</summary> > :bangbang: **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion ````` </details> <!-- suggestion_end --> <!-- This is an auto-generated comment by CodeRabbit -->
jobs: jobs:
validate-pr-title: build:
name: conventional pull requests
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04
permissions:
contents: read
pull-requests: read
packages: read
statuses: write
steps: steps:
- name: PR Conventional Commit Validation - name: conventional pull requests check
uses: ytanikin/PRConventionalCommits@1.1.0 uses: ytanikin/PRConventionalCommits@1.1.0
with: with:
task_types: '["build","chore","ci","docs","feat","fix","perf","refactor","revert","style","test"]' task_types: '["build","chore","ci","docs","feat","fix","perf","refactor","revert","style","test"]'

37
.github/workflows/lint.yml vendored Normal file
View File

@ -0,0 +1,37 @@
name: lint
on:
pull_request:
types: [ opened, synchronize, reopened, edited ]
permissions: { }
coderabbitai[bot] commented 2024-08-15 11:53:17 +00:00 (Migrated from github.com)
Review
Copy Link

Define explicit permissions for security.

The addition of an empty permissions block at the top level is unnecessary since specific permissions are already defined within the build job. Consider removing it to avoid confusion.

- permissions: { }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**Define explicit permissions for security.** The addition of an empty `permissions` block at the top level is unnecessary since specific permissions are already defined within the `build` job. Consider removing it to avoid confusion. ```diff - permissions: { } ``` <!-- suggestion_start --> <details> <summary>Committable suggestion</summary> > :bangbang: **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion ````` </details> <!-- suggestion_end --> <!-- This is an auto-generated comment by CodeRabbit -->
jobs:
build:
name: lint
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: read
packages: read
statuses: write
steps:
- name: checkout code
uses: actions/checkout@v4
with:
# Super-linter needs the full git history to get the list of files that changed across commits
fetch-depth: 0
- name: Super-linter check
uses: super-linter/super-linter@v6.9.0 # x-release-please-version
env:
# to report GitHub Actions status checks
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VALIDATE_ALL_CODEBASE: false
FIX_CSS_PRETTIER: true
FIX_HTML_PRETTIER: true
FIX_JAVASCRIPT_ES: true
FIX_JSON_PRETTIER: true
FIX_RUST_2021: true
FIX_RUST_CLIPPY: true
FIX_TYPESCRIPT_ES: true
FIX_YAML_PRETTIER: true