matous-volf/todo-baggins
1
0
Fork 0
Code Issues 26 Pull Requests Actions Projects 1 Activity

ci: GitHub action for code linting #6

Merged
matous-volf merged 5 commits from ci/lint-check into main 2024-08-15 11:55:20 +00:00
Conversation 5 Commits 5 Files Changed 3 +2 -1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 943f0d48ca - Show all commits

3
.github/workflows/conventional-pull-requests.yml vendored
View File

@@ -5,7 +5,8 @@ on:
types: [ opened, synchronize, reopened, edited ] types: [ opened, synchronize, reopened, edited ]
jobs: jobs:
validate-pr-title: build:
coderabbitai[bot] commented 2024-08-15 11:53:17 +00:00 (Migrated from github.com)
Review
Copy Link

Define explicit permissions for security.

The addition of an empty permissions block at the top level is unnecessary since specific permissions are already defined within the build job. Consider removing it to avoid confusion.

- permissions: { }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**Define explicit permissions for security.** The addition of an empty `permissions` block at the top level is unnecessary since specific permissions are already defined within the `build` job. Consider removing it to avoid confusion. ```diff - permissions: { } ``` <!-- suggestion_start --> <details> <summary>Committable suggestion</summary> > :bangbang: **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion ````` </details> <!-- suggestion_end --> <!-- This is an auto-generated comment by CodeRabbit -->
name: conventional pull requests
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04
steps: steps:
- name: conventional pull requests check - name: conventional pull requests check