matous-volf/todo-baggins
matous-volf/todo-baggins
1
0
Fork 0
Code Issues 23 Pull Requests Actions Projects 1 Activity

ci: GitHub action for code linting #6

Merged
matous-volf merged 5 commits from ci/lint-check into main 2024-08-15 11:55:20 +00:00
Conversation 5 Commits 5 Files Changed 3 +15
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2d1f1aa05b - Show all commits

7
.github/workflows/conventional-commits.yml vendored
View File

@ -4,10 +4,17 @@ on:
pull_request:
types: [ opened, synchronize, reopened, edited ]
permissions: { }
coderabbitai[bot] commented 2024-08-15 11:53:17 +00:00 (Migrated from github.com)
Review
Copy Link

Define explicit permissions for security.

The addition of an empty permissions block at the top level is unnecessary since specific permissions are already defined within the build job. Consider removing it to avoid confusion.

- permissions: { }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**Define explicit permissions for security.** The addition of an empty `permissions` block at the top level is unnecessary since specific permissions are already defined within the `build` job. Consider removing it to avoid confusion. ```diff - permissions: { } ``` <!-- suggestion_start --> <details> <summary>Committable suggestion</summary> > :bangbang: **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion ````` </details> <!-- suggestion_end --> <!-- This is an auto-generated comment by CodeRabbit -->
jobs:
build:
name: conventional commits
runs-on: ubuntu-22.04
permissions:
contents: read
pull-requests: read
packages: read
statuses: write
steps:
- name: checkout code
uses: actions/checkout@v3

7
.github/workflows/conventional-pull-requests.yml vendored
View File

@ -4,10 +4,17 @@ on:
pull_request:
types: [ opened, synchronize, reopened, edited ]
permissions: { }
coderabbitai[bot] commented 2024-08-15 11:53:17 +00:00 (Migrated from github.com)
Review
Copy Link

Define explicit permissions for security.

The addition of an empty permissions block at the top level is unnecessary since specific permissions are already defined within the build job. Consider removing it to avoid confusion.

- permissions: { }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**Define explicit permissions for security.** The addition of an empty `permissions` block at the top level is unnecessary since specific permissions are already defined within the `build` job. Consider removing it to avoid confusion. ```diff - permissions: { } ``` <!-- suggestion_start --> <details> <summary>Committable suggestion</summary> > :bangbang: **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion ````` </details> <!-- suggestion_end --> <!-- This is an auto-generated comment by CodeRabbit -->
jobs:
build:
name: conventional pull requests
runs-on: ubuntu-22.04
permissions:
contents: read
pull-requests: read
packages: read
statuses: write
steps:
- name: conventional pull requests check
uses: ytanikin/PRConventionalCommits@1.1.0

1
.github/workflows/lint.yml vendored
View File

@ -12,6 +12,7 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: read
packages: read
statuses: write
steps: