matous-volf/todo-baggins
matous-volf/todo-baggins
1
0
Fork 0
Code Issues 23 Pull Requests Actions Projects 1 Activity

feat: progressive web app support #48

Merged
matous-volf merged 5 commits from feat/pwa-support into main 2024-09-15 16:33:13 +00:00
Conversation 7 Commits 5 Files Changed 7 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 99dc95c122 - Show all commits

2
assets/manifest.json
View File

@ -4,7 +4,7 @@
coderabbitai[bot] commented 2024-09-13 14:20:37 +00:00 (Migrated from github.com)
Review
Copy Link

LGTM! The web app manifest looks good.

The manifest file is syntactically correct and includes the key properties. Great job!

Consider adding these optional improvements:

  1. Add a description property to provide a general description of what the web app does.
  2. Instead of one icon with the any size value, provide multiple fixed size icon images for optimal clarity on various devices. For example:
"icons": [
  {
    "src": "/images/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  },
  {
    "src": "/images/icon-512.png", 
    "sizes": "512x512",
    "type": "image/png"
  }
]
**LGTM! The web app manifest looks good.** The manifest file is syntactically correct and includes the key properties. Great job! Consider adding these optional improvements: 1. Add a `description` property to provide a general description of what the web app does. 2. Instead of one icon with the `any` size value, provide multiple fixed size icon images for optimal clarity on various devices. For example: ```json "icons": [ { "src": "/images/icon-192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/images/icon-512.png", "sizes": "512x512", "type": "image/png" } ] ``` <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2024-09-13 14:20:37 +00:00 (Migrated from github.com)
Review
Copy Link

LGTM! The web app manifest looks good.

The manifest file is syntactically correct and includes the key properties. Great job!

Consider adding these optional improvements:

  1. Add a description property to provide a general description of what the web app does.
  2. Instead of one icon with the any size value, provide multiple fixed size icon images for optimal clarity on various devices. For example:
"icons": [
  {
    "src": "/images/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  },
  {
    "src": "/images/icon-512.png", 
    "sizes": "512x512",
    "type": "image/png"
  }
]
**LGTM! The web app manifest looks good.** The manifest file is syntactically correct and includes the key properties. Great job! Consider adding these optional improvements: 1. Add a `description` property to provide a general description of what the web app does. 2. Instead of one icon with the `any` size value, provide multiple fixed size icon images for optimal clarity on various devices. For example: ```json "icons": [ { "src": "/images/icon-192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/images/icon-512.png", "sizes": "512x512", "type": "image/png" } ] ``` <!-- This is an auto-generated comment by CodeRabbit -->
"start_url": "/", "start_url": "/",
"display": "standalone", "display": "standalone",
"background_color": "#27272a", "background_color": "#27272a",
"theme_color": "#e4e4e7", "theme_color": "#27272a",
coderabbitai[bot] commented 2024-09-13 14:20:37 +00:00 (Migrated from github.com)
Review
Copy Link

LGTM! The web app manifest looks good.

The manifest file is syntactically correct and includes the key properties. Great job!

Consider adding these optional improvements:

  1. Add a description property to provide a general description of what the web app does.
  2. Instead of one icon with the any size value, provide multiple fixed size icon images for optimal clarity on various devices. For example:
"icons": [
  {
    "src": "/images/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  },
  {
    "src": "/images/icon-512.png", 
    "sizes": "512x512",
    "type": "image/png"
  }
]
**LGTM! The web app manifest looks good.** The manifest file is syntactically correct and includes the key properties. Great job! Consider adding these optional improvements: 1. Add a `description` property to provide a general description of what the web app does. 2. Instead of one icon with the `any` size value, provide multiple fixed size icon images for optimal clarity on various devices. For example: ```json "icons": [ { "src": "/images/icon-192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/images/icon-512.png", "sizes": "512x512", "type": "image/png" } ] ``` <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2024-09-13 14:20:37 +00:00 (Migrated from github.com)
Review
Copy Link

LGTM! The web app manifest looks good.

The manifest file is syntactically correct and includes the key properties. Great job!

Consider adding these optional improvements:

  1. Add a description property to provide a general description of what the web app does.
  2. Instead of one icon with the any size value, provide multiple fixed size icon images for optimal clarity on various devices. For example:
"icons": [
  {
    "src": "/images/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  },
  {
    "src": "/images/icon-512.png", 
    "sizes": "512x512",
    "type": "image/png"
  }
]
**LGTM! The web app manifest looks good.** The manifest file is syntactically correct and includes the key properties. Great job! Consider adding these optional improvements: 1. Add a `description` property to provide a general description of what the web app does. 2. Instead of one icon with the `any` size value, provide multiple fixed size icon images for optimal clarity on various devices. For example: ```json "icons": [ { "src": "/images/icon-192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/images/icon-512.png", "sizes": "512x512", "type": "image/png" } ] ``` <!-- This is an auto-generated comment by CodeRabbit -->
"icons": [ "icons": [
{ {
"src": "/images/icon.png", "src": "/images/icon.png",

coderabbitai[bot] commented 2024-09-13 14:20:37 +00:00 (Migrated from github.com)
Review
Copy Link

LGTM! The web app manifest looks good.

The manifest file is syntactically correct and includes the key properties. Great job!

Consider adding these optional improvements:

  1. Add a description property to provide a general description of what the web app does.
  2. Instead of one icon with the any size value, provide multiple fixed size icon images for optimal clarity on various devices. For example:
"icons": [
  {
    "src": "/images/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  },
  {
    "src": "/images/icon-512.png", 
    "sizes": "512x512",
    "type": "image/png"
  }
]
**LGTM! The web app manifest looks good.** The manifest file is syntactically correct and includes the key properties. Great job! Consider adding these optional improvements: 1. Add a `description` property to provide a general description of what the web app does. 2. Instead of one icon with the `any` size value, provide multiple fixed size icon images for optimal clarity on various devices. For example: ```json "icons": [ { "src": "/images/icon-192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/images/icon-512.png", "sizes": "512x512", "type": "image/png" } ] ``` <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2024-09-13 14:20:37 +00:00 (Migrated from github.com)
Review
Copy Link

LGTM! The web app manifest looks good.

The manifest file is syntactically correct and includes the key properties. Great job!

Consider adding these optional improvements:

  1. Add a description property to provide a general description of what the web app does.
  2. Instead of one icon with the any size value, provide multiple fixed size icon images for optimal clarity on various devices. For example:
"icons": [
  {
    "src": "/images/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  },
  {
    "src": "/images/icon-512.png", 
    "sizes": "512x512",
    "type": "image/png"
  }
]
**LGTM! The web app manifest looks good.** The manifest file is syntactically correct and includes the key properties. Great job! Consider adding these optional improvements: 1. Add a `description` property to provide a general description of what the web app does. 2. Instead of one icon with the `any` size value, provide multiple fixed size icon images for optimal clarity on various devices. For example: ```json "icons": [ { "src": "/images/icon-192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/images/icon-512.png", "sizes": "512x512", "type": "image/png" } ] ``` <!-- This is an auto-generated comment by CodeRabbit -->