matous-volf/todo-baggins
matous-volf/todo-baggins
1
0
Fork 0
Code Issues 23 Pull Requests Actions Projects 1 Activity

feat: deployment #46

Merged
matous-volf merged 11 commits from feat/deployment into main 2024-09-13 10:42:20 +00:00
Conversation 3 Commits 11 Files Changed 8 +5 -2
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d868b6a143 - Show all commits

7
docker-compose-prod.yml
View File

@ -2,14 +2,17 @@ services:
app: app:
build: build:
dockerfile: docker/prod/app/Dockerfile dockerfile: docker/prod/app/Dockerfile
networks:
- default
- web-server-network
restart: always restart: always
depends_on: [ "db" ] depends_on: [ "db" ]
coderabbitai[bot] commented 2024-09-13 09:25:52 +00:00 (Migrated from github.com)
Review
Copy Link

Minor formatting issues detected by static analysis.

The static analysis tool flagged extra spaces inside the brackets on lines 9 and 13. While this does not affect the functionality, it's recommended to remove the extra spaces for consistency and readability.

Apply this diff to fix the formatting issues:

-    depends_on: [ "db" ]
+    depends_on: ["db"]

-    volumes: [ "db_data:/var/lib/postgresql/data" ]
+    volumes: ["db_data:/var/lib/postgresql/data"]

Also applies to: 13-13

Tools
yamllint

[error] 9-9: too many spaces inside brackets

(brackets)

[error] 9-9: too many spaces inside brackets

(brackets)

**Minor formatting issues detected by static analysis.** The static analysis tool flagged extra spaces inside the brackets on lines 9 and 13. While this does not affect the functionality, it's recommended to remove the extra spaces for consistency and readability. Apply this diff to fix the formatting issues: ```diff - depends_on: [ "db" ] + depends_on: ["db"] - volumes: [ "db_data:/var/lib/postgresql/data" ] + volumes: ["db_data:/var/lib/postgresql/data"] ``` Also applies to: 13-13 <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 9-9: too many spaces inside brackets (brackets) --- [error] 9-9: too many spaces inside brackets (brackets) </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit -->
networks:
- web-server-network
db: db:
image: postgres:16.4-bookworm image: postgres:16.4-bookworm
volumes: [ "db_data:/var/lib/postgresql/data" ] volumes: [ "db_data:/var/lib/postgresql/data" ]
networks:
- default
environment: environment:
POSTGRES_DB: todo_baggins POSTGRES_DB: todo_baggins
POSTGRES_USER: app POSTGRES_USER: app