feat: text input value trimming #57
Reference in New Issue
Block a user
No description provided.
Delete Branch "feat/text-input-value-trimming"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary by CodeRabbit
edit_taskfunction to accept mutable references for in-place modifications.Walkthrough
The changes involve modifications to the
create_project,edit_project,create_subtask,edit_subtask,create_task, andedit_taskfunctions across three files. Each of these functions now includes a step to sanitize thetitlefield by trimming whitespace, ensuring that leading or trailing spaces are removed before validation. Additionally, theedit_taskfunction's signature has been updated to accept a mutable reference to allow in-place modifications. These updates aim to enhance input handling and data integrity.Changes
src/server/projects.rscreate_projectandedit_projectto sanitize thetitlefield by trimming whitespace.src/server/subtasks.rscreate_subtaskandedit_subtaskto sanitize thetitlefield by trimming whitespace.src/server/tasks.rscreate_taskandedit_taskto sanitize thetitlefield by trimming whitespace; modifiededit_taskto accept a mutable reference.Possibly related PRs
src/server/tasks.rsrelated to the addition of thedelete_taskfunction are relevant because they involve modifications to the same file as the main PR, which also includes changes to theedit_taskfunction in that file.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share
Tips
Chat
There are 3 ways to chat with CodeRabbit:
--
I pushed a fix in commit <commit_id>, please review it.--
Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.@coderabbitaiin a new review comment at the desired location with your query. Examples:--
@coderabbitai generate unit testing code for this file.--
@coderabbitai modularize this function.@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:--
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.--
@coderabbitai read src/utils.ts and generate unit testing code.--
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.--
@coderabbitai help me debug CodeRabbit configuration file.Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.Other keywords and placeholders
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed.@coderabbitai summaryto generate the high-level summary at a specific location in the PR description.@coderabbitaianywhere in the PR title to generate the title automatically.CodeRabbit Configuration File (
.coderabbit.yaml).coderabbit.yamlfile to the root of your repository.# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.jsonDocumentation and Community
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Commits
Files that changed from the base of the PR and between
92dc7a7c88and962b68d446.Files selected for processing (3)
Additional comments not posted (4)
@@ -15,0 +15,4 @@// TODO: replace with model sanitization (https://github.com/matous-volf/todo-baggins/issues/13)let mut new_project = new_project;new_project.title = new_project.title.trim().to_owned();LGTM! Remember to address the TODO comment.
The changes improve data integrity by ensuring that any leading or trailing spaces in the project title are removed before validation occurs. This is a good temporary measure until a more comprehensive model sanitization is implemented.
Please ensure that the TODO comment is addressed in a timely manner and the issue linked in the comment is resolved.
Do you want me to open a GitHub issue to track this task?
@@ -20,0 +20,4 @@// TODO: replace with model sanitization (https://github.com/matous-volf/todo-baggins/issues/13)let mut new_task = new_task;new_task.title = new_task.title.trim().to_owned();Good temporary solution, but address the TODO comment.
Trimming whitespace from the
titlefield is a good temporary solution to ensure data consistency. However, as mentioned in the TODO comment, it's recommended to implement a more comprehensive model sanitization approach for better validation and security.Please prioritize the model sanitization task referenced in the GitHub issue to replace this temporary solution.
Consider extracting the input validation logic into a separate function.
The input validation logic that trims whitespace from the
titlefield is duplicated in thecreate_taskandedit_taskfunctions. This violates the DRY principle and can lead to maintenance issues.Consider extracting the input validation logic into a separate function and calling it from both
create_taskandedit_taskfunctions. This will centralize the validation logic and make it easier to update in the future.For example:
Then, in
create_taskandedit_taskfunctions:Also applies to: 116-119