matous-volf/todo-baggins
matous-volf/todo-baggins
1
0
Fork 0
Code Issues 23 Pull Requests Actions Projects 1 Activity

Loading indicators #20

New Issue
Open
opened 2024-09-06 05:26:52 +00:00 by coderabbitai[bot] · 4 comments
coderabbitai[bot] commented 2024-09-06 05:26:52 +00:00 (Migrated from github.com)
Copy Link

The CategoryPage component in src/components/pages/category_page.rs currently contains a TODO comment indicating the need for a loading indicator during data fetching. Implementing this feature would enhance the user experience by providing visual feedback while tasks are being loaded.

File: src/components/pages/category_page.rs
Line: 24

This issue was requested by @matous-volf in this comment.

The `CategoryPage` component in `src/components/pages/category_page.rs` currently contains a TODO comment indicating the need for a loading indicator during data fetching. Implementing this feature would enhance the user experience by providing visual feedback while tasks are being loaded. **File:** `src/components/pages/category_page.rs` **Line:** 24 This issue was requested by @matous-volf in [this comment](https://github.com/matous-volf/todo-baggins/pull/19#discussion_r1745846403).
matous-volf commented 2024-09-06 05:35:54 +00:00 (Migrated from github.com)
Copy Link

@coderabbitai Make this issue more general – implementing loading indicatiors accross the project.

@coderabbitai Make this issue more general – implementing loading indicatiors accross the project.
coderabbitai[bot] commented 2024-09-06 05:45:27 +00:00 (Migrated from github.com)
Copy Link

Tip

For best results, initiate chat on the files or code changes.

@matous-volf, understood! I'll update the issue to reflect the broader scope of implementing loading indicators across the project. Would you like me to search for other components that may require loading indicators, so we can ensure all relevant areas are covered?

<!-- This is an auto-generated reply by CodeRabbit --> > [!TIP] > For best results, initiate chat on the files or code changes. @matous-volf, understood! I'll update the issue to reflect the broader scope of implementing loading indicators across the project. Would you like me to search for other components that may require loading indicators, so we can ensure all relevant areas are covered?
matous-volf commented 2024-09-06 07:08:58 +00:00 (Migrated from github.com)
Copy Link

@coderabbitai Sure.

@coderabbitai Sure.
coderabbitai[bot] commented 2024-09-06 07:10:08 +00:00 (Migrated from github.com)
Copy Link

Tip

For best results, initiate chat on the files or code changes.

@matous-volf, I've identified several components across the project that may require loading indicators:

  1. CategoryPage (src/components/pages/category_page.rs)
  2. ProjectsPage (src/components/pages/projects_page.rs)
  3. CategoryTodayPage (src/components/pages/category_today_page.rs)
  4. CategoryCalendarPage (src/components/pages/category_calendar_page.rs)
  5. ProjectForm (src/components/project_form.rs)
  6. TaskForm (src/components/task_form.rs)
  7. BottomPanel (src/components/bottom_panel.rs)

Additionally, there are async functions in src/server/tasks.rs, src/server/projects.rs, src/query/tasks.rs, and src/query/projects.rs that might also benefit from loading indicators, depending on how they are used in the UI.

I'll go ahead and update the issue to reflect this broader scope.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for components that might require loading indicators by looking for common patterns related to data fetching or asynchronous operations.
rg -A 5 'fetch|await|async|loading|TODO' --glob '*.rs'

Length of output: 7787

<!-- This is an auto-generated reply by CodeRabbit --> > [!TIP] > For best results, initiate chat on the files or code changes. @matous-volf, I've identified several components across the project that may require loading indicators: 1. **CategoryPage** (`src/components/pages/category_page.rs`) 2. **ProjectsPage** (`src/components/pages/projects_page.rs`) 3. **CategoryTodayPage** (`src/components/pages/category_today_page.rs`) 4. **CategoryCalendarPage** (`src/components/pages/category_calendar_page.rs`) 5. **ProjectForm** (`src/components/project_form.rs`) 6. **TaskForm** (`src/components/task_form.rs`) 7. **BottomPanel** (`src/components/bottom_panel.rs`) Additionally, there are async functions in `src/server/tasks.rs`, `src/server/projects.rs`, `src/query/tasks.rs`, and `src/query/projects.rs` that might also benefit from loading indicators, depending on how they are used in the UI. I'll go ahead and update the issue to reflect this broader scope. <details> <summary>Analysis chain</summary> </details> <details> <summary>Scripts executed</summary> The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Search for components that might require loading indicators by looking for common patterns related to data fetching or asynchronous operations. rg -A 5 'fetch|await|async|loading|TODO' --glob '*.rs' ``` Length of output: 7787 </details>
matous-volf added this to the Backlog project 2024-12-29 15:29:29 +00:00
matous-volf added the
feature
 label 2024-12-29 15:42:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
feature
refactor
No Label
feature
Milestone
No items
No Milestone
Projects
Clear projects
No project Backlog
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matous-volf/todo-baggins#20
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?